Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foreman_ygg_worker to 0.3.0 #11296

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from

Conversation

adamruzicka
Copy link

No description provided.

@adamruzicka
Copy link
Author

adamruzicka commented Sep 26, 2024

Please hold on until I get a confirmation that we should be creating the group ourselves.

Edit: Not needed, yggdrasil ships a sysusers definition which handles the group creation

@adamruzicka adamruzicka marked this pull request as ready for review September 30, 2024 14:20
@evgeni
Copy link
Member

evgeni commented Oct 14, 2024

@adamruzicka could you please rebase on the latest changes by Ewoud in rpm/develop?

@adamruzicka
Copy link
Author

Well, this is tricky. foreman_ygg_worker-0.3.0 is now compatible with yggdrasil 0.2.z and 0.4.z (not sure about 0.3.z, probably too but who knows). However, the way we deploy yggdrasil is not compatible with yggdrasil >=0.4 until #11317 lands

@adamruzicka
Copy link
Author

[test rpm-copr]

Copy link

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack from the functional side, tested together with theforeman/katello-pull-transport-migrate#8

@evgeni
Copy link
Member

evgeni commented Oct 24, 2024

Packaging wise this looks fine.
What I am confused about is the user deployment implications.

(assuming ygg 0.4, for all of the above)

@adamruzicka
Copy link
Author

In general yes to all three.

Users who want to deploy a fresh, mqtt connected host, just need foreman_ygg_worker and the config gets created by the process that is deploying f_y_w, right?

Also yes, with "the process" being tweaked in theforeman/foreman#10340

@evgeni
Copy link
Member

evgeni commented Oct 24, 2024

And you can't do the stuff from #11317 in %post of foreman_ygg_worker because that'd make the setup incompatible with ygg 0.2?
My brain tries really hard to tell me a new package is (UX wise) a bad idea.

@adamruzicka
Copy link
Author

I need the post thingy to be run when yggdrasil itself gets updated to handle the service rename, which doesn't necessarily have to happen in the same transaction as when f_y_w is changed, so having it in f_y_w's post could miss this situation. The config file changes could be done at any time, but the service rename is tricky.

@evgeni
Copy link
Member

evgeni commented Oct 30, 2024

My brain tries really hard to tell me a new package is (UX wise) a bad idea.

My main concern was that people need to install that package somehow, but in most cases (most: https://github.com/theforeman/foreman-packaging/pull/11317/files#r1822445063) this will happen automatically, so it's probably fine.

I still don't like this. But I also don't see a good way around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants