Update rubygem-foreman_rh_cloud to 10.0.2 #11281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-processor
bot
added
Not yet reviewed
RPM
Stable branch
evgeni
reviewed
Sep 23, 2024
| @@ -30,7 +30,7 @@ BuildRequires: ruby < 4 | |||
| BuildRequires: rubygems-devel | |||
| BuildRequires: rubygem(foreman_ansible) | |||
| BuildRequires: rubygem(foreman-tasks) | |||
| BuildRequires: rubygem(katello) | |||
| BuildRequires: rubygem(katello) >= 4.14.0.rc1.1 | |||
There was a problem hiding this comment.
No matching package to install: 'rubygem(katello) >= 4.14.0.rc1.1'
That's not an RPM version definition, but Ruby, and RPM gets confused by that. (4.14.0.rc1.1 is "bigger" than 4.14.0 which we have).
There was a problem hiding this comment.
I am guessing I need to a make a new gem with it pinned correctly in the gem spec?
There was a problem hiding this comment.
Packaging as such doesn't look inside the gem.
So editing it here to just read >= 4.14.0 should be perfectly fine.
(And then update it in the gem whenever you do the next release)
chris1984
force-pushed
the
rhcloud616convert
branch
from
8085d66
to
859f6b3
Compare
evgeni
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to pin against katello 4.14 which was not GA yet with this PR since we were pulling in an older version of Katello which was causing tests to fail and not having the convert2rhel Katello PR.
Shim suggested we pin this way since we were still in RC mode for Katello 4.14 and he said this would pull in the pre release gems.
Let me know if you want me to just remove it out of the specfile so it builds correctly, or we need a new gem with it either pinned in a better way or removed from the gemspec now that Katello 4.14.0 is GA