-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #34758: Match rename of remote_execution::ssh to remote_executio… #759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if you all have the same timestamps so it's easy to correlate. The easiest way to achieve this is to call ./bin/create-migration
with all scenarios it applies to.
answers['foreman_proxy::plugin::remote_execution::script'] = answers['foreman_proxy::plugin::remote_execution::ssh'] | ||
answers.delete('foreman_proxy::plugin::remote_execution::ssh') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answers['foreman_proxy::plugin::remote_execution::script'] = answers['foreman_proxy::plugin::remote_execution::ssh'] | |
answers.delete('foreman_proxy::plugin::remote_execution::ssh') | |
answers['foreman_proxy::plugin::remote_execution::script'] = answers.delete('foreman_proxy::plugin::remote_execution::ssh') |
config/katello.migrations/220411132123-rename-rex-ssh-rex-script.rb
Outdated
Show resolved
Hide resolved
Also inconsistent dashes vs underscores in migration file names? |
Sadly that was already the case before and now we at least (try) to keep them consistent per scenario. In #736 I tried to align them but didn't get around to finishing it. |
[test foreman-installer] |
@evgeni This is also ready now |
…n::script
See theforeman/puppet-foreman_proxy#734