Skip to content

Commit

Permalink
Refs #33277: Unset foreman_service_puma_workers and foreman_service_p…
Browse files Browse the repository at this point in the history
…uma_threads_max if set to default value

This resets the foreman_server_puma_workers value to pick up the
newest default which is undef. The change from theforeman/puppet-foreman#986
makes the default a dynamically calculated value that should
provide better out of the box experience for users.

This resets the value of foreman_service_puma_threads_max to the new
default value coming from puppet-foreman of 5. The original default of
16 has been determined to likely be too high for Ruby MRI based installations
and resetting to the recommended default by Puma should result in less
wasted resources. Users can opt to increase this value based on
their environments.
  • Loading branch information
ehelms committed Aug 25, 2021
1 parent dcd015c commit 4c129ef
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# https://github.com/theforeman/puppet-foreman/commit/533c1f3be8069139d7375841019afeb7c1102830
if answers['foreman'].is_a?(Hash)
if answers['foreman']['foreman_service_puma_workers'] == 2
answers['foreman'].delete('foreman_service_puma_workers')
end
end

if answers['foreman'].is_a?(Hash)
if answers['foreman']['foreman_service_puma_threads_max'] == 16
answers['foreman'].delete('foreman_service_puma_threads_max')
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# https://github.com/theforeman/puppet-foreman/commit/533c1f3be8069139d7375841019afeb7c1102830
if answers['foreman'].is_a?(Hash)
if answers['foreman']['foreman_service_puma_workers'] == 2
answers['foreman'].delete('foreman_service_puma_workers')
end
end

if answers['foreman'].is_a?(Hash)
if answers['foreman']['foreman_service_puma_threads_max'] == 16
answers['foreman'].delete('foreman_service_puma_threads_max')
end
end

0 comments on commit 4c129ef

Please sign in to comment.