Add rbenv to Jenkins nodes #2022
Conversation
|
|
||
| rbenv::build { '3.1.0': } | ||
| rbenv::build { '3.0.4': } | ||
| rbenv::build { '2.7.6': } |
There was a problem hiding this comment.
These are not the most up to date versions of Ruby but our choices are dictated by what's available from ruby-build.
There was a problem hiding this comment.
"from ruby-build in EPEL", which we can influence, if we want.
Looking at https://canidepend.com/#ruby, we'd want 2.7.8, 3.0.4, 3.1.2 to match EL?
|
|
||
| # rbenv | ||
| if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] != '7' { | ||
| include slave::rbenv |
There was a problem hiding this comment.
Intent is to add this to all our EL8 nodes, switch our code to it and then we can drop RVM and then update to EL9.
| include slave::rvm | ||
| if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] != '9' { | ||
| include slave::rvm | ||
| } |
There was a problem hiding this comment.
| include slave::rvm | |
| if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] != '9' { | |
| include slave::rvm | |
| } | |
| if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] != '9' { | |
| include slave::rvm | |
| } |
Otherwise you always include rvm ;)
| # global => true, | ||
| # } | ||
| # | ||
| define rbenv::build ( |
There was a problem hiding this comment.
I must admit I find the name of this define odd.
Yes, it's using ruby-build under the hood, but the rbenv command is rbenv install and to be even more precise, I'd probably not use the "action" (build/install) but the "object" (ruby) that we're managing here and call it rbenv::ruby.
That all said, this is based on the work in jdowning/rbenv and I have no idea how much we want to diverge from it, naming wise.
There was a problem hiding this comment.
No real preference from me
| @@ -167,5 +167,12 @@ | |||
| include slave::postgresql | |||
|
|
|||
| # RVM | |||
| include slave::rvm | |||
| if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] != '9' { | |||
There was a problem hiding this comment.
This means Debian nodes don't get neither rvm nor rbenv, which is fine as we do not run unittests there, but needs tests fixed
No description provided.