Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger a backup as pre command instead on relying on discourse cron #1932

Merged
merged 1 commit into from
Sep 28, 2023
Merged

trigger a backup as pre command instead on relying on discourse cron #1932

merged 1 commit into from
Sep 28, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 28, 2023

No description provided.

@evgeni evgeni added this to the discourse migration milestone Sep 28, 2023
ekohl
ekohl approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Should we then disable the cron in Discourse itself?

Another thought for a follow up: scan we add extraction of the backup to allow for deduplication (#1844)?

@evgeni
Copy link
Member Author

evgeni commented Sep 28, 2023

I like this. Should we then disable the cron in Discourse itself?

That was my idea, yes.

Another thought for a follow up: scan we add extraction of the backup to allow for deduplication (#1844)?

I'd like to defer thinking about this to another day :)

@evgeni evgeni merged commit 09a2863 into theforeman:master Sep 28, 2023
2 checks passed
@evgeni evgeni deleted the trigger-backup-discourse branch September 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
discourse migration
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @ekohl