Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Presence implementation #233

Merged
merged 1 commit into from
Feb 11, 2024
Merged

General Presence implementation #233

merged 1 commit into from
Feb 11, 2024

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Feb 7, 2024

General Presence with present/absent messages - Discovery independent

Checklist:

  • I have created the pull request against the latest development branch
  • I have added only one feature/fix per PR and the code change compiles without warnings
  • I accept the Developer Certificate of Origin (DCO).

@DigiH DigiH force-pushed the general-pres branch 2 times, most recently from 9aed505 to da1fc3e Compare February 7, 2024 16:51
@DigiH DigiH marked this pull request as draft February 7, 2024 16:54
@DigiH DigiH force-pushed the general-pres branch 5 times, most recently from dd469eb to a391b6e Compare February 8, 2024 12:44
@DigiH DigiH marked this pull request as ready for review February 8, 2024 13:29
@DigiH DigiH marked this pull request as draft February 8, 2024 13:53
@DigiH DigiH force-pushed the general-pres branch 3 times, most recently from c7b60d1 to 8f61258 Compare February 8, 2024 14:49
@DigiH DigiH marked this pull request as ready for review February 8, 2024 14:50
@DigiH DigiH force-pushed the general-pres branch 2 times, most recently from d4348ec to b4057f9 Compare February 8, 2024 15:45
General Presence with present/absent messages - Discovery independent
Copy link
Member

@koenvervloesem koenvervloesem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DigiH DigiH merged commit 5264ef4 into development Feb 11, 2024
7 checks passed
@DigiH DigiH deleted the general-pres branch February 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants