Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Factory namespace due to new directory architecture of the TDBM generated file #21

Open
wants to merge 1 commit into
base: 7.0
Choose a base branch
from
Open

Change Factory namespace due to new directory architecture of the TDBM generated file #21

wants to merge 1 commit into from

Conversation

xhuberty
Copy link
Contributor

@xhuberty xhuberty commented Mar 9, 2016

No description provided.

@moufmouf
Copy link
Member

This will work with TDBM 4, but will fail with TDBM 3. And there is no logical link between Splash and TDBM anyway.
I'm wondering what we should do...

Solution 1: we could say Splash 7 matches TDBM 4 (this is mostly true, I don't know any Splash 7 deployement with TDBM 3)
Solution 2: we could try to find the DaoFactory class (maybe using class_exists, or by checking for the file in the filesystem)
Solution 3: we could simply drop support for the DaoFactory (because it is suboptimal compared to injecting single DAOs)...

What do you think would be best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhuberty @moufmouf