Introduces a very early debugger feature for quaesar #25
Conversation
dartfnm
commented
Oct 9, 2024
dartfnm
commented
- EASTL lib
- added some not very functional debugger windows
- CMake flags for VC Windows development
+ EASTL lib + added some not very functional debugger windows + CMake flags for VC Windows development
dartfnm
force-pushed
the
debugger-start
branch
2 times, most recently
from
853c4a4
to
7f6ef90
Compare
make clang & gcc happy gcc compile errors fixed
dartfnm
force-pushed
the
debugger-start
branch
from
7f6ef90
to
a4c447d
Compare
external/dear_imgui/CMakeLists.txt
Outdated
| @@ -1,7 +1,7 @@ | |||
| cmake_minimum_required(VERSION 3.10) | |||
| project(imgui) | |||
|
|
|||
| if (APPLE OR LINUX OR UNIX) | |||
| if (APPLE OR LINUX) | |||
There was a problem hiding this comment.
This has to be if (APPLE OR LINUX OR UNIX) to work for some reason.
There was a problem hiding this comment.
This one has to be fixed as well (there are two checks in the same file)
There was a problem hiding this comment.
Perhaps there should be
if (APPLE OR LINUX OR UNIX)
target_include_directories(imgui PRIVATE ${SDL2_INCLUDE_DIRS})```
Instead of
`target_link_libraries(imgui PRIVATE ${SDL2_LIBRARIES})`
external/dear_imgui/CMakeLists.txt
Outdated
| @@ -21,8 +21,8 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}/backends) | |||
| # Create static library | |||
| add_library(imgui STATIC ${IMGUI_SOURCES}) | |||
|
|
|||
| if (APPLE OR LINUX OR UNIX) | |||
| target_include_directories(imgui PRIVATE ${SDL2_INCLUDE_DIRS}) | |||
| if (APPLE OR LINUX) | |||
There was a problem hiding this comment.
Same here if (APPLE OR LINUX OR UNIX) to work for some reason.
There was a problem hiding this comment.
Fixed.
I also wanted to ask what version of clang-format checks formatting?
sudo apt-get install -y clang-format
Because I have tried on different versions of clang-format and it gives different results compare with your check.
There was a problem hiding this comment.
Specifically the problem with
AlignTrailingComments: true
Because its syntax is already deprecated since clang-format 16.
There was a problem hiding this comment.
Yeah, lets remove that from the clang-format file
dartfnm
force-pushed
the
debugger-start
branch
from
fcac9a2
to
281d5b5
Compare
dartfnm
force-pushed
the
debugger-start
branch
from
281d5b5
to
d9d657d
Compare
|
Thanks! Hopefully merging should be a bit easier after the initial one. |
