Skip to content

Commit

Permalink
fix: js patch functions that are executed indefinitely (#263)
Browse files Browse the repository at this point in the history
the argument passed to the patch function is meant to be ++callCount
so that the value actually increments.

fixes #262
  • Loading branch information
fdintino authored Aug 13, 2024
1 parent f894371 commit 91b8614
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions nested_admin/static/nested_admin/dist/nested_admin.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nested_admin/static/nested_admin/dist/nested_admin.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion nested_admin/static/nested_admin/dist/nested_admin.min.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions nested_admin/static/nested_admin/src/nested-admin/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ djangoFuncs.forEach((funcName) => {
return;
}
if (typeof $.fn[funcName] === "undefined") {
return setTimeout(() => patchDjangoFunction(callCount++), 12);
return setTimeout(() => patchDjangoFunction(++callCount), 12);
}
$.fn[funcName] = (function (oldFn) {
return function django_fn_patch() {
Expand Down Expand Up @@ -388,7 +388,7 @@ grpFuncs.forEach((funcName) => {
typeof window.grp === "undefined" ||
typeof window.grp.jQuery.fn[funcName] === "undefined"
) {
return setTimeout(() => patchGrpFunction(callCount++), 12);
return setTimeout(() => patchGrpFunction(++callCount), 12);
}
window.grp.jQuery.fn[funcName] = (function (oldFn) {
return function grp_fn_patch() {
Expand Down

0 comments on commit 91b8614

Please sign in to comment.