Code

Naming#79

Code

Merged

AA-Turner merged 49 commits intomasterthe-scouts/incognita:masterfrom namingthe-scouts/incognita:namingCopy head branch name to clipboardMar 29, 2021

+908-1,099

Commits

Commits on Mar 17, 2021

• Standardise on scout_data

  AA-Turner

  committed
  0c4015c

• region_ids_mapping -> boundary_codes

  AA-Turner

  committed
  f3e2ef3

Commits on Mar 21, 2021

• Normalise boundary_codes columns

  AA-Turner

  committed
  e341a34

• Update usages of geography.metadata with new fields

  AA-Turner

  committed
  34661ff

• Move ONS pd boundaries config to toml file

  AA-Turner

  committed
  a78d97d

• Update boundary config with human-readable names

  AA-Turner

  committed
  5930bc9

• Rename <boundary group>.<boundary id>.name to .key

  AA-Turner

  committed
  6738606

• Combine Geography.__init__ and _load_boundary

  AA-Turner

  committed
  7e07d00

Commits on Mar 22, 2021

• Rewrite ScoutCensus.columns as a pydantic model

  AA-Turner

  committed
  e4324e5

• Combine Geography.__init__ and _load_boundary

  AA-Turner

  committed
  0290bad

Commits on Mar 23, 2021

• Disambiguate ScoutData.columns -> filterable_columns

  AA-Turner

  committed
  be8b9aa

• Update Reports.filter_boundaries.

  Show description for 16bdb8c
  AA-Turner

  committed
  16bdb8c

Commits on Mar 24, 2021

• Disambiguate ScoutData.data -> census_data

  AA-Turner

  committed
  5494de3

• Make ons_pd.fields and scout_data.filterable_columns sets of strings

  AA-Turner

  committed
  c2e6861

• All boundary filter functions to return updated boundary_codes

  AA-Turner

  committed
  57a79ce

• Simplify Reports.filter_boundaries

  AA-Turner

  committed
  f781f44

• Remove Map.scout_data class attribute

  AA-Turner

  committed
  941e071

• Remove lots of Map class attributes

  AA-Turner

  committed
  4349776

• Clean up layer management

  AA-Turner

  committed
  03e96ed

• Extract Map.set_boundary

  AA-Turner

  committed
  c42fc11

• Update misc functions, Map.add_sections_to_map

  AA-Turner

  committed
  f56c4f1

• Misc fixes

  AA-Turner

  committed
  cd3d24a

• Remove indirect dimension dict in Map.add_areas

  AA-Turner

  committed
  8cf02e3

• Tidy up add_areas, remove Map.layers

  AA-Turner

  committed
  30153a2

• Simplify Map.add_areas scale

  AA-Turner

  committed
  f762fa8

• Simplify Map._load_boundary further, normalise shapefile columns

  AA-Turner

  committed
  0d01ca3

• Spelling

  AA-Turner

  committed
  5ba3519

• Formatting

  AA-Turner

  committed
  4a94a5c

• Minor changes to _map_* methods

  AA-Turner

  committed
  ef93e5c

• Remove *_region_of_colour

  AA-Turner

  committed
  6f94f67

• Rework of Map.add_meeting_places_to_map

  AA-Turner

  committed
  4aa0dfb

• More work in Map.add_meeting_places_to_map

  AA-Turner

  committed
  92e7340

• Don't construct new dataframe

  AA-Turner

  committed
  32eec23

• Update Reports._ons_to_district_mapping

  AA-Turner

  committed
  713552f

• Remove a sub-groupby in Reports.create_boundary_report

  AA-Turner

  committed
  3c2e013

• Remove _young_people_numbers_groupby

  AA-Turner

  committed
  2200ad1

Commits on Mar 26, 2021

• Remove _groups_groupby, vectorise operations

  AA-Turner

  committed
  129c020

• Add _groups_groupby replacement

  AA-Turner

  committed
  a8e9dc1

• Add logging at file load points

  AA-Turner

  committed
  83f2a62

• Speed up Map.add_meeting_places_to_map (~200%)

  AA-Turner

  committed
  0ad2fb2

• Hack for attribution string

  AA-Turner

  committed
  cf93127

• Marker data to set

  AA-Turner

  committed
  e990af0

• Only calculate youth membership / awards overview data if it will be used

  AA-Turner

  committed
  4329fbc

Commits on Mar 27, 2021

• Remove section_from_type

  AA-Turner

  committed
  f207b41

Commits on Mar 28, 2021

• Reports.create_boundary_report options now type set

  AA-Turner

  committed
  8d2d0c6

• Reduce usages of getattr

  AA-Turner

  committed
  47a25cf

Commits on Mar 29, 2021

• Formatting

  AA-Turner

  committed
  53b0c9f

• Update test_scout_data_columns

  AA-Turner

  committed
  91fe6cf

• Extend test deadlines (again...)

  AA-Turner

  committed
  06b582d