Interface object implementation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 22, 2024 14:05
kamilkisiela
force-pushed
the
interface-object
branch
from
e80c5ff
to
34e9f69
Compare
|
any news with a review? I've already forgotten what I wrote there... 😄 |
kamilkisiela
pushed a commit
that referenced
this pull request
Mar 15, 2024
This should close #7 The code is dirty... but it seems to be working **leftovers** - [x] there are some global tests failing... I need to check and address those. --------- Co-authored-by: Troy Kohler <[email protected]>
kamilkisiela
added a commit
that referenced
this pull request
Mar 15, 2024
Closes #7 --------- Co-authored-by: T <[email protected]> Co-authored-by: Troy Kohler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #7
The code is dirty... but it seems to be working
leftovers