-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP <figure> semantics #37
base: master
Are you sure you want to change the base?
Conversation
, | ||
type: 'image' | ||
src: 'http://a.com/b.jpg' | ||
caption: '<h1>Title</h1><p>Desc</p>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this block.caption rather than block.metadata.caption?
Should it be html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergie RFC
@bergie after p2p meetup can we figure out html consistency? |
Do we want to allow formatting and / or links within |
@forresto yes, if we allow figcaption, we should allow inline mark-up there. |
Can we clean this up semantically? |
@forresto right now title and caption are assumed to be text-only in the block format |
@bergie what about using metadata Or saving caption to |
@forresto if we want properties where the inline mark-up is retained, we should use new keys for them in order to not break backwards compat. Same should apply for example to |
@bergie, what would be the appropriate keys for properties w/ inline markup? This is a powerful & needed step forward. Using metadata fields like Being consistent with @cbchouinard's stated contract between DS & the data-model: the content of the blocks are ensured to be represented, metadata will be a nice-to-have but not guaranteed: let's move forward on allowing rich sub-block content immediately and keeping it outside of @bergie, do you have a general API in mind for blocks to expose inline markup content (ie sub-blocks)? A general (ie recursive) solution would be preferred over an ad-hoc one, yes? I'm assuming these changes can be rolled out without breaking DS or any clients, and new DS & clients v2 can move to new method in .5 days work... |
talking with @forresto, confirmed it will be needed for things like: edit the image caption inline in the editable, edit article block content inline, etc. Basically editable inline cards in Ed & would help catalyze Ed to next level. Most block metadata editing will be moving to a lightbox view. DS needs this to ensure the most important content is rendered. Apps could use it to more easily represent content on cards. Not to mention it gives the possibility of having semi-rich text (links and what-not) in areas that reasonably should be have this possibility. |
@bergie @jonnor @aretecode is there another issue somewhere in APIs or elsewhere on the topic of exposing a block's inline html content outside of |
Until we have a recursive
→
|
@forresto yep, we can do that. The |
Note that it appears |
No description provided.