Added text alignment feature to editor and improved some styles for user-friendly interface #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my comment in PR #1752, the changes made are as follows:
We've used SVGs for the 'text alignment' newly added feature because Unicode characters doesn't exist for that and use SVGs for ordered, and unordered lists to provide a clearer and more user-friendly interface.
I fixed the SVG color for dark mode too.
The modifications in SquireUI.less were designed to streamline the editor's layout and enhance its overall aesthetics. Specifically, we adopted a flexbox-based approach for the toolbar buttons, replacing the previous scroll-based layout. Additionally, we ensured correct displaying of SVG icons and the button order for right-to-left (RTL) languages.
The adjustments made to NextcloudV25+/styles.css were aimed at preserving a consistent and user-friendly appearance across different themes by overriding certain default styles.
These changes will make to improve and more completely the editor and, I'll fix it If you have any ideas or suggestions for accepting this PR.
Thank you