Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/assisted tagging geo loader #1480

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix/assisted tagging geo loader #1480

merged 2 commits into from
Apr 16, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Apr 12, 2024

Changes

  • add dataloader in draftentry geoarea
  • add dataloader in draftentry predication tags

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 requested a review from thenav56 April 12, 2024 10:09
@sudan45 sudan45 marked this pull request as draft April 12, 2024 10:09
@sudan45 sudan45 force-pushed the fix/assisted-tagging-geo-loader branch from b7163a7 to 154404e Compare April 12, 2024 10:15
@sudan45 sudan45 force-pushed the fix/assisted-tagging-geo-loader branch from 154404e to 2675fb3 Compare April 12, 2024 10:36
@sudan45 sudan45 marked this pull request as ready for review April 12, 2024 10:38
thenav56
thenav56 requested changes Apr 12, 2024
View reviewed changes
apps/assisted_tagging/dataloaders.py Outdated Show resolved Hide resolved
apps/assisted_tagging/dataloaders.py Outdated Show resolved Hide resolved
apps/assisted_tagging/dataloaders.py Outdated Show resolved Hide resolved
apps/assisted_tagging/schema.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the fix/assisted-tagging-geo-loader branch from 2675fb3 to 5f70f94 Compare April 12, 2024 11:44
@sudan45 sudan45 requested a review from thenav56 April 12, 2024 11:45
@sudan45 sudan45 force-pushed the fix/assisted-tagging-geo-loader branch 2 times, most recently from f730cff to 5f7a049 Compare April 15, 2024 05:20
k9845
k9845 suggested changes Apr 15, 2024
View reviewed changes
apps/assisted_tagging/schema.py Outdated Show resolved Hide resolved
apps/assisted_tagging/dataloaders.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the fix/assisted-tagging-geo-loader branch from 5f7a049 to 20764a5 Compare April 16, 2024 03:55
@sudan45 sudan45 force-pushed the fix/assisted-tagging-geo-loader branch from 20764a5 to a9d602d Compare April 16, 2024 03:59
@sudan45 sudan45 requested a review from k9845 April 16, 2024 04:42
@AdityaKhatri AdityaKhatri merged commit 3a1cbc7 into develop Apr 16, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/assisted-tagging-geo-loader branch April 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@k9845 k9845 k9845 approved these changes

@thenav56 thenav56 thenav56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sudan45 @thenav56 @k9845 @susilnem @AdityaKhatri