Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql mutation node for analysis-framework membership #1450

Closed

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Apr 3, 2024

Addresses Implement Graphql mutation node for analysis-framework membership

Changes

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@susilnem susilnem requested review from thenav56 and sudan45 April 3, 2024 07:08
@susilnem
Copy link
Member Author

susilnem commented Apr 3, 2024

@thenav56 What to do with the Framework Membership permission?

@susilnem susilnem self-assigned this Apr 5, 2024
@thenav56
Copy link
Member

thenav56 commented Apr 8, 2024

@susilnem I think we already have mutations for this. Can you check the analysis_framework_membership_bulk?
https://github.com/the-deep/server/blob/develop/apps/analysis_framework/tests/test_mutations.py#L647

@thenav56 thenav56 marked this pull request as draft April 8, 2024 10:01
@sudan45 sudan45 closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants