Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create graphql node for creating new organization #1445

Merged
merged 3 commits into from
May 15, 2024
Merged

Create graphql node for creating new organization #1445

merged 3 commits into from
May 15, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Apr 2, 2024 •
edited by thenav56
Loading

Addresses

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

susilnem
susilnem reviewed Apr 8, 2024
View reviewed changes
apps/organization/mutation.py Outdated Show resolved Hide resolved
apps/organization/serializers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 self-assigned this Apr 8, 2024
@sudan45 sudan45 changed the base branch from develop to project/rest-to-graphql April 8, 2024 14:57
@sudan45 sudan45 force-pushed the features/organization-rest-to-graphql branch 4 times, most recently from a1a7ee6 to 8244f4c Compare April 10, 2024 10:47
susilnem
susilnem reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sudan45 sudan45 changed the base branch from project/rest-to-graphql to develop April 30, 2024 05:12
@sudan45 sudan45 requested review from thenav56, k9845 and susilnem April 30, 2024 05:23
thenav56
thenav56 requested changes May 1, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apps/organization/tests/test_mutations.py Show resolved Hide resolved
@sudan45 sudan45 force-pushed the features/organization-rest-to-graphql branch from 8244f4c to a3a588c Compare May 2, 2024 04:16
@sudan45 sudan45 assigned AdityaKhatri and subinasr and unassigned sudan45 May 2, 2024
@subinasr subinasr changed the title Features/organization rest to graphql Create graphql node for creating new organization May 9, 2024
@subinasr subinasr mentioned this pull request May 15, 2024
Merged
11 tasks
@subinasr subinasr force-pushed the features/organization-rest-to-graphql branch from a3a588c to 655d66d Compare May 15, 2024 05:25
@subinasr subinasr removed their assignment May 15, 2024
@AdityaKhatri AdityaKhatri merged commit 0870533 into develop May 15, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the features/organization-rest-to-graphql branch May 15, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenav56 thenav56 thenav56 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Awaiting requested review from Rup-Narayan-Rajbanshi

@k9845 k9845 Awaiting requested review from k9845

@susilnem susilnem Awaiting requested review from susilnem

Assignees

@AdityaKhatri AdityaKhatri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sudan45 @thenav56 @k9845 @susilnem @AdityaKhatri @subinasr