Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null value error handled in viz settings #1412

Closed
wants to merge 1 commit into from
Closed

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Jan 23, 2024

Addresses #1393

Mention related users here if any.
@thenav56

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets check for failed test case.

@AdityaKhatri AdityaKhatri self-assigned this Feb 13, 2024
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We will need to migrate existing data to new format as well.

@sudan45 sudan45 force-pushed the fix/viz-settings branch 3 times, most recently from e662777 to 5d55c8c Compare February 14, 2024 10:20
@sudan45 sudan45 requested a review from thenav56 March 15, 2024 05:34
- Fix Null value error issue with viz settings mutation
- Update test cases related to AF properties mutation
@sudan45 sudan45 closed this Apr 10, 2024
@thenav56 thenav56 deleted the fix/viz-settings branch April 10, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants