Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/new assisted tagging #1388

Merged
merged 19 commits into from
Dec 21, 2023
Merged

Feature/new assisted tagging #1388

merged 19 commits into from
Dec 21, 2023

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Nov 21, 2023 •
edited
Loading

Addresses #1376

Changes

  • Detailed list or prose of changes
  • Breaking changes
  • Changes to configurations

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 marked this pull request as draft November 21, 2023 04:01
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch 4 times, most recently from 8715c61 to 1bc5fb8 Compare November 22, 2023 09:04
@subinasr subinasr changed the base branch from feature/use-new-text-extraction-endpoint to develop November 22, 2023 09:08
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch from 1bc5fb8 to e682efc Compare November 23, 2023 09:52
@sudan45 sudan45 requested a review from thenav56 November 23, 2023 10:35
@sudan45 sudan45 self-assigned this Nov 23, 2023
@subinasr subinasr mentioned this pull request Nov 24, 2023
Merged
11 tasks
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch 3 times, most recently from 2fb7142 to 98c1086 Compare November 24, 2023 10:18
@thenav56 thenav56 force-pushed the feature/new-assisted-tagging branch from 98c1086 to 7ca705c Compare November 27, 2023 04:37
@thenav56 thenav56 changed the base branch from develop to feature/use-new-text-extraction-endpoint November 27, 2023 04:37
@thenav56 thenav56 force-pushed the feature/use-new-text-extraction-endpoint branch from dc760c3 to 5e1d99c Compare November 27, 2023 04:38
Base automatically changed from feature/use-new-text-extraction-endpoint to project/auto-extraction November 28, 2023 04:06
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch from 7ca705c to cae8307 Compare November 28, 2023 05:07
Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sudan45 lets check for graphql schema and flake8 issues.

@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch 5 times, most recently from ac4eb13 to 2be2f1a Compare December 4, 2023 12:40
thenav56
thenav56 requested changes Dec 11, 2023
View reviewed changes
apps/assisted_tagging/admin.py Show resolved Hide resolved
apps/assisted_tagging/filters.py Outdated Show resolved Hide resolved
apps/assisted_tagging/filters.py Outdated Show resolved Hide resolved
apps/assisted_tagging/filters.py Outdated Show resolved Hide resolved
apps/assisted_tagging/models.py Show resolved Hide resolved
apps/deepl_integration/serializers.py Outdated Show resolved Hide resolved
deep/deepl.py Outdated Show resolved Hide resolved
apps/lead/models.py Outdated Show resolved Hide resolved
apps/lead/models.py Outdated Show resolved Hide resolved
apps/lead/migrations/0049_auto_20231121_0926.py Outdated Show resolved Hide resolved
thenav56
thenav56 requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NLP callback optimization. Let's do this at the end after writing all the tests.

apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch from 8daf49e to 5bf846d Compare December 12, 2023 04:01
@sudan45 sudan45 requested a review from thenav56 December 20, 2023 08:57
@AdityaKhatri AdityaKhatri marked this pull request as ready for review December 20, 2023 09:52
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch 3 times, most recently from a20da8f to 2a92844 Compare December 20, 2023 11:46
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch 3 times, most recently from d531f35 to 8147fe9 Compare December 21, 2023 04:13
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch from 8147fe9 to 33ba176 Compare December 21, 2023 04:23
thenav56
thenav56 requested changes Dec 21, 2023
View reviewed changes
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
apps/deepl_integration/views.py Outdated Show resolved Hide resolved
apps/assisted_tagging/serializers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 requested a review from thenav56 December 21, 2023 06:32
thenav56
thenav56 requested changes Dec 21, 2023
View reviewed changes
apps/assisted_tagging/admin.py Outdated Show resolved Hide resolved
apps/assisted_tagging/admin.py Show resolved Hide resolved
apps/assisted_tagging/enums.py Outdated Show resolved Hide resolved
apps/assisted_tagging/filters.py Outdated Show resolved Hide resolved
apps/assisted_tagging/models.py Outdated Show resolved Hide resolved
apps/lead/schema.py Outdated Show resolved Hide resolved
apps/deepl_integration/serializers.py Outdated Show resolved Hide resolved
apps/deepl_integration/handlers.py Show resolved Hide resolved
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
apps/assisted_tagging/mutation.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/new-assisted-tagging branch 8 times, most recently from 7f066b4 to 840739a Compare December 21, 2023 11:09
@sudan45 @thenav56
Filter added in admin.py
d277a14 
- Fix test cases
@thenav56 thenav56 force-pushed the feature/new-assisted-tagging branch from 840739a to d277a14 Compare December 21, 2023 11:39
@thenav56 thenav56 force-pushed the feature/new-assisted-tagging branch from 30aaea9 to be38aa8 Compare December 21, 2023 12:39
@thenav56
Hack test fix
be38aa8 
- Real configuration is having issue in test case
@thenav56 thenav56 merged commit ffb969b into project/auto-extraction Dec 21, 2023
4 checks passed
@thenav56 thenav56 deleted the feature/new-assisted-tagging branch December 21, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenav56 thenav56 thenav56 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Awaiting requested review from Rup-Narayan-Rajbanshi

Assignees

@sudan45 sudan45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudan45 @thenav56 @Rup-Narayan-Rajbanshi