Feature/add filter analysis framework to show recently used framework #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenav56
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Looks good.
Let's also push the new graphql schema
https://github.com/the-deep/server/actions/runs/6250258951/job/16968710026?pr=1369
https://github.com/the-deep/server/blob/develop/.github/workflows/ci.yml#L49-L58
docker-compose exec web ./manage.py graphql_schema --out schema.graphqlNow it should be fine to add tests.
11 tasks
thenav56
requested changes
Oct 2, 2023
thenav56
requested changes
Oct 9, 2023
RobertKoikai
force-pushed
the
feature/Add-Filter-analysisFramework-to-show-recently-used-framework
branch
from
987bdab to
412ac04
Compare
thenav56
force-pushed
the
feature/Add-Filter-analysisFramework-to-show-recently-used-framework
branch
3 times, most recently
from
2fff12b to
e5f8cc9
Compare
Related error: `AttributeError: 'TestProjectGeneralMutationSnapshotTest' object has no attribute '_snapshot_file'`
thenav56
approved these changes
Nov 6, 2023
thenav56
deleted the
feature/Add-Filter-analysisFramework-to-show-recently-used-framework
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses : Add a filter in analysisFramework query to show most recently used frameworks #1350
Depends on the-deep/server
Changes
Update the AnalysisFrameworkFilterSet to show Recently Used Framework
This PR doesn't introduce any:
printThis PR contains valid: