Return None instead of invalid url

the-deep · Oct 20, 2023 · a872c8b · a872c8b
1 parent dd5cb0d
commit a872c8b
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/apps/export/schema.py b/apps/export/schema.py
@@ -63,7 +63,7 @@ class Meta:
     status = graphene.Field(graphene.NonNull(ExportStatusEnum))
     export_type = graphene.Field(graphene.NonNull(ExportExportTypeEnum))
     file = graphene.Field(FileFieldType)
-    file_download_url = graphene.String()
+    file_download_url = graphene.String(required=False)
     # Filter Data
     filters = graphene.Field(LeadsFilterDataType)
     filters_data = graphene.Field(LeadFilterDataType)
@@ -79,14 +79,15 @@ def resolve_filters_data(root, info):
 
     @staticmethod
     def resolve_file_download_url(root, info, **kwargs):
-        return info.context.request.build_absolute_uri(
-            URLCachedFileField.generate_url(
-                root.file.name,
-                parameters={
-                    'ResponseContentDisposition': f'filename = "{root.title}.{root.format}"'
-                }
+        if root.file and root.file.name:
+            return info.context.request.build_absolute_uri(
+                URLCachedFileField.generate_url(
+                    root.file.name,
+                    parameters={
+                        'ResponseContentDisposition': f'filename = "{root.title}.{root.format}"'
+                    }
+                )
             )
-        )
 
 
 class UserGenericExportType(DjangoObjectType):
@@ -108,22 +109,23 @@ class Meta:
     filters = GenericScalar(required=False)
 
     file = graphene.Field(FileFieldType)
-    file_download_url = graphene.String()
+    file_download_url = graphene.String(required=False)
 
     @staticmethod
     def get_custom_queryset(queryset, info, **kwargs):
         return get_generic_export_qs(info)
 
     @staticmethod
     def resolve_file_download_url(root, info, **kwargs):
-        return info.context.request.build_absolute_uri(
-            URLCachedFileField.generate_url(
-                root.file.name,
-                parameters={
-                    'ResponseContentDisposition': f'filename = "{root.title}.{root.format}"'
-                }
+        if root.file and root.file.name:
+            return info.context.request.build_absolute_uri(
+                URLCachedFileField.generate_url(
+                    root.file.name,
+                    parameters={
+                        'ResponseContentDisposition': f'filename = "{root.title}.{root.format}"'
+                    }
+                )
             )
-        )
 
 
 class UserExportListType(CustomDjangoListObjectType):