Fix attachment issue #2976
Merged
Fix attachment issue #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshathakuri
force-pushed
the
fix/ocr-image-issue
branch
2 times, most recently
from
98f19cd to
f1042e4
Compare
shreeyash07
approved these changes
Jul 31, 2024
subinasr
requested changes
Aug 14, 2024
Comment on lines
-399
to
-415
| const handleAttachmentClick = useCallback((attachment: LeadPreviewAttachmentType) => { | ||
| if (onEntryCreate) { | ||
| onEntryCreate({ | ||
| clientId: randomString(), | ||
| entryType: 'ATTACHMENT', | ||
| lead: leadId, | ||
| leadAttachment: attachment.id, | ||
| excerpt: '', | ||
| droppedExcerpt: '', | ||
| }); | ||
| setLeadAttachmentsMap((oldValue) => ({ | ||
| ...oldValue, | ||
| [attachment.id]: attachment, | ||
| })); | ||
| } | ||
| }, [leadId, onEntryCreate]); | ||
|
|
There was a problem hiding this comment.
Is there a reason we're handling this in 'EntryEdit' and not here?
There was a problem hiding this comment.
@subinasr By adding handleAttachmentClick to the LeftPane Entries, the leadId is utilized in both the secondary and review tabs. Moving it to entryEdit makes the leadId accessible across all tabs, which explains why the image was only visible in the primary tab previously.
AdityaKhatri
force-pushed
the
fix/ocr-image-issue
branch
from
02909af to
0e7e4ba
Compare
AdityaKhatri
force-pushed
the
fix/ocr-image-issue
branch
from
0e7e4ba to
e7a55c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
console.logmeant for debuggingThis PR contains valid: