Contextual data for auto cluster and summarization #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subinasr
requested review from
AdityaKhatri,
tnagorra,
frozenhelium,
samshara,
puranban,
shreeyash07 and
barshathakuri
AdityaKhatri
requested changes
Jun 13, 2024
app/components/TagInput/index.tsx
Outdated
Comment on lines
41
to
43
| const handleTagRemove = useCallback(() => { | ||
| onRemove(label); | ||
| }, [onRemove, label]); |
There was a problem hiding this comment.
use label as tag name and put onRemove in onClick of Button
| @@ -147,6 +158,7 @@ export interface AnalyticalStatementInputProps { | |||
| listeners?: Listeners; | |||
| onSelectedNgramChange: (item: string | undefined) => void; | |||
| framework: Framework; | |||
| frameworkTagLabels: { [x: string]: string }; | |||
There was a problem hiding this comment.
Suggested change
| frameworkTagLabels: { [x: string]: string }; | |
| frameworkTagLabels: Record<string, string>; |
| if (attribute.widgetType === 'MATRIX1D') { | ||
| const pillars = attribute.data?.value; | ||
| const test = Object.keys(pillars ?? []) | ||
| ?.map((pillarKey) => Object.keys(pillars?.[pillarKey] ?? [])) |
There was a problem hiding this comment.
Suggested change
| ?.map((pillarKey) => Object.keys(pillars?.[pillarKey] ?? [])) | |
| ?.map((pillarKey) => Object.keys(pillars?.[pillarKey] ?? {})) |
| } | ||
| if (attribute.widgetType === 'MATRIX1D') { | ||
| const pillars = attribute.data?.value; | ||
| const test = Object.keys(pillars ?? []) |
There was a problem hiding this comment.
Suggested change
| const test = Object.keys(pillars ?? []) | |
| const pillarKeys = Object.keys(pillars ?? []) |
app/views/PillarAnalysis/index.tsx
Outdated
Comment on lines
790
to
831
| const selectedFilters = useMemo(() => ( | ||
| listToMap( | ||
| sourcesFilterValue?.entriesFilterData?.filterableData, | ||
| (d) => d.filterKey, | ||
| (d) => d.valueList, | ||
| ) | ||
| ), [sourcesFilterValue?.entriesFilterData?.filterableData]); | ||
|
|
||
| const selectedFilterKeys = useMemo(() => ( | ||
| Object.keys(selectedFilters ?? {}) | ||
| ), [ | ||
| selectedFilters, | ||
| ]); | ||
|
|
||
| const widgetTagMap = useMemo(() => (frameworkFilters | ||
| ?.map((widget) => { | ||
| if ( | ||
| widget.widgetType === 'SELECT' | ||
| || widget.widgetType === 'MULTISELECT' | ||
| || widget.widgetType === 'ORGANIGRAM' | ||
| || widget.widgetType === 'MATRIX1D' | ||
| || widget.widgetType === 'MATRIX2D' | ||
| ) { | ||
| return widget; | ||
| } | ||
| return undefined; | ||
| }).filter(isDefined).filter( | ||
| (ff) => selectedFilterKeys.includes(ff.key), | ||
| )?.map((ff) => ({ | ||
| key: ff.key, | ||
| options: ff.properties?.options, | ||
| })) | ||
| ), [ | ||
| frameworkFilters, | ||
| selectedFilterKeys, | ||
| ]); | ||
|
|
||
| const widgetTagLabels = useMemo(() => ( | ||
| widgetTagMap?.flatMap( | ||
| (option) => option?.options?.filter( | ||
| (widget) => selectedFilters?.[option.key]?.includes(widget.key), | ||
| )?.map( | ||
| (item: {key: string, label: string}) => item?.label, | ||
| ), | ||
| ).filter(isDefined) | ||
| ), [ | ||
| selectedFilters, | ||
| widgetTagMap, | ||
| ]); |
There was a problem hiding this comment.
do it inside a single useMemo
app/views/PillarAnalysis/index.tsx
Outdated
| ); | ||
|
|
||
| const widgetTagsFromPrimaryTagging: { | ||
| [x: string]: string |
There was a problem hiding this comment.
Suggested change
| [x: string]: string | |
| Record<string, string> |
app/views/PillarAnalysis/index.tsx
Outdated
| @@ -1148,15 +1157,142 @@ function PillarAnalysis() { | |||
| })); | |||
| }, [setSourcesFilterValue]); | |||
|
|
|||
| const entriesForStatements = listToMap( | |||
There was a problem hiding this comment.
Add useMemo for all functions in this page
AdityaKhatri
force-pushed
the
feature/tags-analysis-module
branch
from
1068368 to
86d2c9e
Compare
subinasr
force-pushed
the
feature/tags-analysis-module
branch
from
86d2c9e to
0705da8
Compare
AdityaKhatri
approved these changes
Jun 13, 2024
subinasr
force-pushed
the
feature/tags-analysis-module
branch
2 times, most recently
from
7a4291b to
e9a9c18
Compare
subinasr
force-pushed
the
feature/tags-analysis-module
branch
from
e9a9c18 to
a3af782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
console.logmeant for debugging