Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update reporting module snapshot schema #2934

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Feature/update reporting module snapshot schema #2934

merged 1 commit into from
Apr 26, 2024

Conversation

AdityaKhatri
Copy link
Member

Changes

  • Add map and line chart schema for snapshot in public report view

Depends on: the-deep/server#1486

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks
  • translations

@AdityaKhatri AdityaKhatri requested a review from subinasr April 26, 2024 04:57
@AdityaKhatri AdityaKhatri changed the base branch from develop to project/reporting-module-charts April 26, 2024 04:57
@tnagorra tnagorra merged commit 8bbae34 into project/reporting-module-charts Apr 26, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr approved these changes

@tnagorra tnagorra tnagorra approved these changes

Assignees

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaKhatri @tnagorra @subinasr