-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement graphql queries to fetch project roles #2885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreeyash07
force-pushed
the
feature/project-roles-rest-graphql
branch
4 times, most recently
from
April 5, 2024 05:59
eb06a37
to
82d0375
Compare
AdityaKhatri
requested changes
Apr 5, 2024
Comment on lines
219
to
238
const roles = useMemo(() => { | ||
if (isNotDefined(activeUserRole)) { | ||
return undefined; | ||
} | ||
const currentUserRoleLevel = projectRolesResponse?.results?.find( | ||
(role) => ( | ||
// FIXME: Update this after complete on server side | ||
role.type.toUpperCase() === activeUserRole | ||
), | ||
)?.level; | ||
if (!currentUserRoleLevel) { | ||
return undefined; | ||
} | ||
return projectRolesResponse?.results.filter( | ||
(role) => role.level >= currentUserRoleLevel, | ||
); | ||
}, [ | ||
activeUserRole, | ||
projectRolesResponse, | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still required.
shreeyash07
force-pushed
the
feature/project-roles-rest-graphql
branch
2 times, most recently
from
April 9, 2024 06:24
75ccc21
to
396b36b
Compare
@shreeyash07 The query has been updated from server side. Can you reflect those changes and also rebase this branch with latest develop? |
shreeyash07
force-pushed
the
feature/project-roles-rest-graphql
branch
from
April 17, 2024 09:55
396b36b
to
1b68494
Compare
shreeyash07
force-pushed
the
feature/project-roles-rest-graphql
branch
from
April 17, 2024 09:57
1b68494
to
3f3e661
Compare
AdityaKhatri
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaced rest api with graphql in project roles options
This PR doesn't introduce any:
console.log
meant for debuggingThis PR contains valid: