Minor fixes in ARY from feedback document #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaKhatri
requested changes
Feb 13, 2024
| @@ -40,6 +42,7 @@ function AddStakeholderButton<T extends string>(props: Props<T>) { | |||
| <AddStakeholderModal | |||
| {...stakeholderModalProps} | |||
| onModalClose={hideModal} | |||
| fromAssessment={fromAssessment} | |||
There was a problem hiding this comment.
Instead of this, send label
Comment on lines
214
to
216
| label={fromAssessment | ||
| ? 'Assessment Lead' | ||
| : _ts('project.detail.stakeholders', 'leadOrganization')} |
There was a problem hiding this comment.
get label from prop and then change set the default to lead organization. lets remove _ts as well. Not necessary right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
console.logmeant for debugging