Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ary dashboard tab visibility #2828

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix ary dashboard tab visibility #2828

merged 1 commit into from
Feb 15, 2024

Conversation

AdityaKhatri
Copy link
Member

Changes

  • Fix ary dashboard tab visibility
  • Use lead published date as opposed to entry created date in analysis module

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks
  • translations

@AdityaKhatri AdityaKhatri requested a review from subinasr January 26, 2024 10:26
@ghost
Copy link

ghost commented Jan 26, 2024 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

subinasr
subinasr requested changes Feb 14, 2024
View reviewed changes
app/Base/configs/routes.tsx Outdated Show resolved Hide resolved
@AdityaKhatri AdityaKhatri force-pushed the fix/ary-dashboard-tab-visibility branch 2 times, most recently from 9961ecf to 6bc8787 Compare February 15, 2024 09:58
@AdityaKhatri AdityaKhatri force-pushed the fix/ary-dashboard-tab-visibility branch from 6bc8787 to b71785a Compare February 15, 2024 10:03
@subinasr subinasr merged commit 01b5dbc into develop Feb 15, 2024
5 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/ary-dashboard-tab-visibility branch February 15, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr approved these changes

Assignees

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaKhatri @subinasr