Add text zoom in simplified text #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaKhatri
requested changes
Dec 28, 2023
Comment on lines
20
to
22
| &.extra-small{ | ||
| font-size: calc(var(--base-font-size) - 2 * var(--diff)); | ||
| } |
There was a problem hiding this comment.
I think the font we have should be the smallest allowed font and only allow increments. What do you think?
There was a problem hiding this comment.
That is what the process is now. Take a look please.
subinasr
force-pushed
the
fix/simplified-text-view
branch
from
424fc24 to
7779d31
Compare
AdityaKhatri
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
console.logmeant for debugging