Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for auto extraction incompatible leads #2801

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

subinasr
Copy link
Contributor

Changes

  • Add error messages for old leads that do not support automatic extraction.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

@ghost
Copy link

ghost commented Dec 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Comment on lines 563 to 567
{!isAutoExtractionCompatible && (
<Message
message="Ooops. Looks like this source does not support Auto extraction at the moment. Please try it with a new source."
/>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to title or hover on info icon next to the button

@subinasr subinasr force-pushed the fix/add-error-message branch from d81a8a3 to 72dc821 Compare December 20, 2023 06:23
@AdityaKhatri AdityaKhatri merged commit a02fc9d into project/auto-extraction Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants