Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI and UX issues in new assessment registry #2798

Merged

Conversation

AdityaKhatri
Copy link
Member

Changes

  • Fix minor issues reported by QA and Analyst team

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks
  • translations

@ghost
Copy link

ghost commented Dec 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@puranban puranban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdityaKhatri , Please don't forget to check type error yarn typechek.
As there is type error in the file app/views/ProjectEdit/ProjectDetailsForm/index.tsx:401:30

@AdityaKhatri AdityaKhatri force-pushed the fix/address-analyst-team-issues-ary branch from 0b26131 to 9c18c2b Compare December 20, 2023 08:18
@puranban puranban merged commit 9194c32 into project/new-assessment-registry Dec 20, 2023
3 of 4 checks passed
@puranban puranban deleted the fix/address-analyst-team-issues-ary branch December 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants