Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add twitter and ochaopt support for preview proxy #2791

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Add twitter and ochaopt support for preview proxy #2791

merged 2 commits into from
Nov 9, 2023

Conversation

AdityaKhatri
Copy link
Member

@AdityaKhatri AdityaKhatri commented Nov 8, 2023 •
edited
Loading

Changes

  • Add twitter and ochaopt support for preview proxy

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks
  • translations

@AdityaKhatri AdityaKhatri requested a review from thenav56 November 8, 2023 10:18
@ghost
Copy link

ghost commented Nov 8, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@AdityaKhatri AdityaKhatri requested a review from subinasr November 9, 2023 07:04
@AdityaKhatri AdityaKhatri assigned subinasr and unassigned thenav56 Nov 9, 2023
@subinasr subinasr merged commit 6c2e3f4 into develop Nov 9, 2023
3 checks passed
@subinasr subinasr deleted the feature/add-twitter-ochaopt-support branch November 9, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr approved these changes

@thenav56 thenav56 Awaiting requested review from thenav56

Assignees

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaKhatri @subinasr @thenav56