Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/report builder #2745

Merged
merged 23 commits into from
Nov 8, 2023
Merged

Feature/report builder #2745

merged 23 commits into from
Nov 8, 2023

Conversation

AdityaKhatri
Copy link
Member

@AdityaKhatri AdityaKhatri commented Sep 1, 2023 •
edited
Loading

Changes

  • Create report builder

Depends on: the-deep/server#1357

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks
  • translations

@ghost
Copy link

ghost commented Sep 1, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@AdityaKhatri AdityaKhatri force-pushed the feature/report-builder branch from 4856723 to 1b5339d Compare September 1, 2023 05:26
@AdityaKhatri AdityaKhatri changed the base branch from develop to project/reporting-module September 1, 2023 05:27
@AdityaKhatri AdityaKhatri force-pushed the feature/report-builder branch 4 times, most recently from 72029af to c54efa5 Compare September 7, 2023 05:50
@AdityaKhatri AdityaKhatri force-pushed the feature/report-builder branch 6 times, most recently from bd90783 to 9895e34 Compare September 20, 2023 11:29
@AdityaKhatri AdityaKhatri marked this pull request as ready for review September 27, 2023 06:49
tnagorra
tnagorra previously requested changes Sep 27, 2023
View reviewed changes
app/Base/configs/routes.tsx Outdated Show resolved Hide resolved
app/components/Portal/index.tsx Outdated Show resolved Hide resolved
app/views/PublicReportView/index.tsx Outdated Show resolved Hide resolved
app/views/PublicReportView/index.tsx Outdated Show resolved Hide resolved
app/views/AnalysisDashboard/ReportsModal/index.tsx Outdated Show resolved Hide resolved
app/views/ReportEdit/index.tsx Outdated Show resolved Hide resolved
app/views/ReportEdit/index.tsx Outdated Show resolved Hide resolved
app/views/ReportEdit/index.tsx Outdated Show resolved Hide resolved
app/views/ReportEdit/index.tsx Outdated Show resolved Hide resolved
app/views/ReportEdit/index.tsx Outdated Show resolved Hide resolved
barshathakuri
barshathakuri previously approved these changes Sep 28, 2023
View reviewed changes
app/components/report/ReportBuilder/ReportContainer/styles.css Show resolved Hide resolved
app/translate/index.tsx Outdated Show resolved Hide resolved
app/views/ProjectEdit/index.tsx Show resolved Hide resolved
app/views/PublicReportView/index.tsx Show resolved Hide resolved
app/views/ReportEdit/index.tsx Show resolved Hide resolved
puranban
puranban previously approved these changes Oct 31, 2023
View reviewed changes
@AdityaKhatri AdityaKhatri dismissed stale reviews from puranban and barshathakuri via 859f6c4 November 6, 2023 04:55
@AdityaKhatri AdityaKhatri force-pushed the feature/report-builder branch from 8b67810 to 859f6c4 Compare November 6, 2023 04:55
@AdityaKhatri
Add heading content in reporting module
8457c1b
@AdityaKhatri
Add heading edit modal in report
ed9ec0b
@AdityaKhatri
Add text edit modal in report
612ff10
@AdityaKhatri
Add table of contents in reporting module
5d16c24
@AdityaKhatri
Generate report from analysis
30cb23c
@AdityaKhatri
Add report metadata title editor
ceaf18d
@AdityaKhatri
Add create and update report mutations
cde25f7
@AdityaKhatri
Add text styles and schema
7f32bed
@AdityaKhatri
Add image upload in reporting module
ad1b03f 
* Replace DeepReplace
* Add height inputs
@AdityaKhatri
Add cotnainer styling in reports
ce9fa5a
@AdityaKhatri
Add text style fonts and alignments
5b9ec50
@AdityaKhatri
Move edit content to left in report builder
20d4bcf
@AdityaKhatri
Update report container and toc styling
1d1ef31
@AdityaKhatri
Move report components to components folder
f9b96ee
@AdityaKhatri
Separate new DeepReplace to be used only in reports
16e32ab
@AdityaKhatri
Make reports publicly viewable
464f6ee
@AdityaKhatri
Add report links in analysis module
6c504b1
@AdityaKhatri
Disable image upload when report is not created
d57ec57
@AdityaKhatri
Add general configuration in report builder
819eae4
@AdityaKhatri
Add missing non field errors
a291a9b
@AdityaKhatri
Add enable report sharing in project admin panel
e32ba36
@AdityaKhatri AdityaKhatri force-pushed the feature/report-builder branch from 859f6c4 to a291a9b Compare November 7, 2023 09:35
@AdityaKhatri AdityaKhatri changed the base branch from project/reporting-module to develop November 8, 2023 08:18
@AdityaKhatri AdityaKhatri force-pushed the feature/report-builder branch from d707f2d to e32ba36 Compare November 8, 2023 08:19
@AdityaKhatri AdityaKhatri requested a review from tnagorra November 8, 2023 08:22
@subinasr subinasr merged commit e979aad into develop Nov 8, 2023
5 checks passed
@subinasr subinasr deleted the feature/report-builder branch November 8, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr approved these changes

@barshathakuri barshathakuri barshathakuri left review comments

@puranban puranban puranban left review comments

@samshara samshara Awaiting requested review from samshara

@shreeyash07 shreeyash07 Awaiting requested review from shreeyash07

@tnagorra tnagorra Awaiting requested review from tnagorra

Assignees

@tnagorra tnagorra

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdityaKhatri @tnagorra @puranban @barshathakuri @subinasr