chore: test coverage improvements

the-darc · May 15, 2015 · 9acca86 · 9acca86
1 parent bbe7941
commit 9acca86
Show file tree

Hide file tree

Showing 14 changed files with 83 additions and 40 deletions.
diff --git a/gulpfile.js b/gulpfile.js
@@ -9,7 +9,8 @@ var gulp = require('gulp'),
 
 var config = {
 	src: {
-		files: 'src/**/*.js'
+		files: 'src/**/*.js',
+		release: 'releases/br-masks.js'
 	},
 	test: {
 		files: 'test/**/*.test.js'
@@ -118,7 +119,7 @@ gulp.task('test-watch', ['jshint', 'build', 'runtest'], function() {
 });
 
 gulp.task('test-coverage', function(done) {
-	gulp.src(config.src.files)
+	gulp.src(config.src.release)
 	.pipe(plugins.istanbul())
 	.pipe(plugins.istanbul.hookRequire())
 	.on('finish', function() {

diff --git a/releases/br-masks-standalone.js b/releases/br-masks-standalone.js
@@ -194,7 +194,7 @@
 /**
  * br-masks
  * A library of masks applicable to several Brazilian data like I.E., CNPJ, CPF and others
- * @version v0.3.4
+ * @version v0.4.0
  * @link http://github.com/the-darc/br-masks
  * @license MIT
  */
@@ -322,10 +322,6 @@ var IE = function(value, uf) {
 	};
 
 	function clearValue (value) {
-		if(!value) {
-			return value;
-		}
-
 		return value.replace(/[^0-9]/g, '');
 	}
 

diff --git a/releases/br-masks-standalone.min.js b/releases/br-masks-standalone.min.js
diff --git a/releases/br-masks.js b/releases/br-masks.js
@@ -1,7 +1,7 @@
 /**
  * br-masks
  * A library of masks applicable to several Brazilian data like I.E., CNPJ, CPF and others
- * @version v0.3.4
+ * @version v0.4.0
  * @link http://github.com/the-darc/br-masks
  * @license MIT
  */
@@ -129,10 +129,6 @@ var IE = function(value, uf) {
 	};
 
 	function clearValue (value) {
-		if(!value) {
-			return value;
-		}
-
 		return value.replace(/[^0-9]/g, '');
 	}
 

diff --git a/releases/br-masks.min.js b/releases/br-masks.min.js
diff --git a/src/ie.js b/src/ie.js
@@ -39,10 +39,6 @@ var IE = function(value, uf) {
 	};
 
 	function clearValue (value) {
-		if(!value) {
-			return value;
-		}
-
 		return value.replace(/[^0-9]/g, '');
 	}
 

diff --git a/test/cep.test.js b/test/cep.test.js
@@ -1,7 +1,16 @@
 var should = require('should'),
-	BrM = require('../releases/br-masks.min');
+	BrM = require('../releases/br-masks');
 
 describe('CEP', function(){
+	it('should not mask empty values', function(done) {
+		should(BrM.cep(null)).be.eql(null);
+		should(BrM.cep(undefined)).be.eql(undefined);
+		should(BrM.cep('')).be.eql('');
+		should(BrM.cep(0)).be.eql(0);
+		should(BrM.cep(false)).be.eql(false);
+		done();
+	});
+
 	it('should maks 30480530 to 30480-530', function(done) {
 		should(BrM.cep('30480530')).be.eql('30480-530');
 		done();

diff --git a/test/cnpj.test.js b/test/cnpj.test.js
@@ -1,7 +1,16 @@
 var should = require('should'),
-	BrM = require('../releases/br-masks.min');
+	BrM = require('../releases/br-masks');
 
 describe('CNPJ', function(){
+	it('should not mask empty values', function(done) {
+		should(BrM.cnpj(null)).be.eql(null);
+		should(BrM.cnpj(undefined)).be.eql(undefined);
+		should(BrM.cnpj('')).be.eql('');
+		should(BrM.cnpj(0)).be.eql(0);
+		should(BrM.cnpj(false)).be.eql(false);
+		done();
+	});
+
 	it('should maks 10157471000161 to 10.157.471/0001-61', function(done) {
 		should(BrM.cnpj('10157471000161')).be.eql('10.157.471/0001-61');
 		done();

diff --git a/test/cpf-cnpj.test.js b/test/cpf-cnpj.test.js
@@ -1,7 +1,16 @@
 var should = require('should'),
-	BrM = require('../releases/br-masks.min');
+	BrM = require('../releases/br-masks');
 
 describe('CPF/CNPJ', function(){
+	it('should not mask empty values', function(done) {
+		should(BrM.cpfCnpj(null)).be.eql(null);
+		should(BrM.cpfCnpj(undefined)).be.eql(undefined);
+		should(BrM.cpfCnpj('')).be.eql('');
+		should(BrM.cpfCnpj(0)).be.eql(0);
+		should(BrM.cpfCnpj(false)).be.eql(false);
+		done();
+	});
+
 	it('should maks 10157471000161 to 10.157.471/0001-61', function(done) {
 		should(BrM.cpfCnpj('10157471000161')).be.eql('10.157.471/0001-61');
 		done();

diff --git a/test/cpf.test.js b/test/cpf.test.js
@@ -1,7 +1,16 @@
 var should = require('should'),
-	BrM = require('../releases/br-masks.min');
+	BrM = require('../releases/br-masks');
 
 describe('CPF ', function() {
+	it('should not mask empty values', function(done) {
+		should(BrM.cpf(null)).be.eql(null);
+		should(BrM.cpf(undefined)).be.eql(undefined);
+		should(BrM.cpf('')).be.eql('');
+		should(BrM.cpf(0)).be.eql(0);
+		should(BrM.cpf(false)).be.eql(false);
+		done();
+	});
+
 	it('should mask 97070868669 to 970.708.686-69', function(done) {
 		should(BrM.cpf('97070868669')).be.eql('970.708.686-69');
 		done();

diff --git a/test/finance.test.js b/test/finance.test.js
@@ -1,5 +1,5 @@
 var should = require('should'),
-	BrM = require('../releases/br-masks.min');
+	BrM = require('../releases/br-masks');
 
 describe('FINANCE', function(){
 	it('should maks 125 to 125.00', function(done) {