Bug/accordion long sections faster #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetkoc182
requested changes
Dec 18, 2019
src/elements/Accordion/Accordion.js
Outdated
| const transitionDuration = Math.max(this.accordionContent.current.clientHeight, 300) > 5000 | ||
| ? 5000 | ||
| const transitionDuration = Math.max(this.accordionContent.current.clientHeight, 300) > 2000 | ||
| ? 1000 |
There was a problem hiding this comment.
this logic makes no sense
if it's gonna take longer than 2 seconds, it'll make it 1 second. else everything else can go up to 2.
both numbers should be 2000
There was a problem hiding this comment.
Isn't it if the client height is more than 2000, make it 1 second? Otherwise, make it whatever seconds the height it is? (height of container, 300px = 300ms)
src/elements/Accordion/Accordion.js
Outdated
| @@ -122,13 +122,17 @@ class Accordion extends Component { | |||
| window.requestAnimationFrame(() => { | |||
| this.accordionContent.current.parentNode.style.height = 0; | |||
|
|
|||
| const closeTransitionDuration = Math.max(this.accordionContent.current.clientHeight, 300) > 2000 | |||
| ? 1000 | |||
There was a problem hiding this comment.
this logic makes no sense
if it's gonna take longer than 2 seconds, it'll make it 1 second. else everything else can go up to 2.
both numbers should be 2000
mehmetkoc182
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.