-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outlineColor attribute, so it can be user defined #41
Open
ParkerK
wants to merge
31
commits into
the-blue-alliance:master
Choose a base branch
from
ParkerK:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
fcd4597
Update SpectrumDialog for outline color support
ParkerK 7efc130
Update ColorItem to support outline color
ParkerK a38c21e
Typo fix
ParkerK 5e69ccf
Update SpectrumPreferenceColor for outline color
ParkerK 3c57fde
Update to support outline color
ParkerK a13d2ec
Support outline color
ParkerK 0aa7777
Use -1 instead of null
ParkerK d8ab799
Outline color
ParkerK 045ed6c
Support outline color
ParkerK 446ac4f
getInt to getColor
ParkerK 98e61b8
getInt to getColor
ParkerK a2a05b3
coloroutline
ParkerK 21c97d2
make jitpack happy
ParkerK 4c640c9
Update SpectrumPalette.java
ParkerK 6f970d1
Update SpectrumDialog.java
ParkerK 9e11bc9
Update SpectrumDialog.java
ParkerK a4bc874
Forgot Colors can be < 0 , so just check != -1, probably a better way…
ParkerK e562573
Whoops colors can be < 0
ParkerK 1538fc1
Update ColorItem.java
ParkerK 8f3567f
revert gradle
f63672d
Updating the gradle to use latest stable plugin while I'm at it
6b036cb
Add two samples - one for black outlines, and one for pink as it's no…
d8a4b8c
Code review changes
bf68d4d
Added google() repo, as the support libraries wouldn't download for m…
0a21c3e
Updated the build.gradles to use the latest support libraries, feel f…
b8dc3ab
whoops, missing =
784869c
Finalize sample
44849d2
Green hurt my eyes, switching to purple
ea08282
remove google() repo
ParkerK dca0744
Typo fix
ParkerK a47f1e6
Update demo_dialog.xml
ParkerK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,16 @@ | |
app:spectrum_outlineWidth="2dp" | ||
app:spectrum_colors="@array/demo_colors_expanded" /> | ||
|
||
<com.thebluealliance.spectrum.SpectrumPreferenceCompat | ||
android:defaultValue="@color/md_indigo_500" | ||
android:key="demo_preference_6" | ||
android:summary="You can make all the colors have the same color border or your choosing" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo, should be "of your choosing". Also, can you stick with one title/summary for both the dialog and preference demos? |
||
android:title="Color preference with green outlines" | ||
app:spectrum_colors="@array/demo_colors" | ||
app:spectrum_outlineWidth="2dp" | ||
app:spectrum_outlineColor="@color/md_green_500" | ||
/> | ||
|
||
<com.thebluealliance.spectrum.SpectrumPreferenceCompat | ||
android:defaultValue="@color/md_red_500" | ||
android:key="demo_preference_3" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line produces the following error in Studio 2.3.3:
Gradle DSL method not found: 'google()'
Are you running the 3.0 beta, or do I have to check my Gradle config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah that's Studio 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer not to use features from 3.0 until it hits stable, let's revert this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shortcut for google's maven - I just wasn't able to download the support libraries from gradle without it - so just ignore it and do what works for you on Studio 2