Changes the tests to not run the demo program #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite was mostly testing the demo program; one test (
TestUnregisteredRootCommand
) only tested demo program behavior, without executing any checks on the core library.This PR replaces all command-executions in tests with programmatic equivalents; it also removes the test for the demo program -- if that program were tested, it'd be best done in
demo/cmd_test.go
, not in the library.Benchmarks show an improvement from 8.6 seconds per run to 500 milliseconds per run, or a 17x speed improvement. More importantly, the tests are more directly testing the library, not the demo program. Improvements are still possible; these tests are functional tests rather than unit tests.
Benchmark for pre-PR:
Post-PR: