change output metric for carbs

thatguy11325 · Oct 13, 2024 · d803cc4 · d803cc4
1 parent 97bc1e0
commit d803cc4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pokemonred_puffer/sweep.py b/pokemonred_puffer/sweep.py
@@ -90,7 +90,6 @@ def launch_sweep(
         wandb_params=WandbLoggingParams(project_name="Pokemon", run_name="Pokemon"),
     )
     params = sweep_config_to_params(base_config, sweep_config)
-    breakpoint()
 
     carbs = CARBS(config=config, params=params)
     sweep_id = wandb.sweep(
@@ -132,16 +131,17 @@ def launch_sweep(
                 elif (
                     run["state"]
                     in [
-                        RunState.failed.value,
+                        # RunState.failed.value,
                         RunState.finished.value,
-                        RunState.crashed.value,
+                        # RunState.crashed.value,
                     ]
                     and run["name"] not in finished
                 ):
                     finished.add(run["name"])
                     summary_metrics = json.loads(run["summaryMetrics"])
                     obs_in = ObservationInParam(
                         input=json.loads(run["config"])["x"]["value"],
+                        # TODO: try out other stats like required count
                         output=summary_metrics["environment/stats/event"],
                         cost=summary_metrics["performance/uptime"],
                     )

diff --git a/pokemonred_puffer/train.py b/pokemonred_puffer/train.py
@@ -307,8 +307,8 @@ def train(
         Vectorization, typer.Option(help="Vectorization method")
     ] = "multiprocessing",
 ):
-    config.vectorization = vectorization
     config = load_from_config(config, debug)
+    config.vectorization = vectorization
     config, env_creator = setup(
         config=config,
         debug=debug,