Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1077
Context / Background
Issue Description:
Describe the current limitation
In the current state you can choose days in the preferences and choose hours per day (for all days).
Describe the proposed feature or enhancement
Add option to choose hours per day for every day.
For example for days: Sun, Tue, Thu set hours-per-day to 10:15 and for Mon, Wed set hours-per-day to 11:45.
What change is being introduced by this PR?
- What changes did you make to achieve the goal? / How did you approach this problem?
BaseCalender.js
FlexibleDayCalender.js
FlexibleMonthCalender.js
time-balance.js
to use these new params, and calculate the time to leave using the new daily hours
If the user works Mon-Fri:
If the user works on Mon and Fri:
- What are the indirect and direct consequences of the change?
Direct Consequences:
Indirect Consequence:
As a result one test case from "npm run test:jest" is failing, this is based on the old logic, where hours per day was a single value, So it was bound to fail, this needs to be updated in the case this issue is resolved.
How will this be tested?
- How will you verify whether your changes worked as expected once merged?