-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating the functional mocha test from Spectron to PlayWright #1062
Migrating the functional mocha test from Spectron to PlayWright #1062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
===========================================
- Coverage 81.79% 56.81% -24.98%
===========================================
Files 22 22
Lines 1401 3270 +1869
Branches 214 419 +205
===========================================
+ Hits 1146 1858 +712
- Misses 255 1412 +1157 ☔ View full report in Codecov by Sentry. |
c0b66fe
to
b7ef380
Compare
e39b027
to
0708a27
Compare
I think we'll have to accept that the coverage report will not be properly done with c8 and esm #34. There doesn't seem to be any workaround either. |
@tupaschoal what do you think? |
I think that's fine @araujoarthur0 |
Related issue
Helps #1037, Closes #653
Context / Background
The mocha test we had was using Spectron, which has sadly been deprecated.
The new suggestion the Electron team made is to use PlayWright. Thus I'm migrating the test to it.
What change is being introduced by this PR?
How will this be tested?
Test is passing fine now.