Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching most expect calls to node assert #1057

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

araujoarthur0
Copy link
Collaborator

Related issue

Helps #1037

Context / Background

As described in #1054, jest no longer works with electron and we'll be switching to mocha. Mocha does not have its own assertion library, so we'll be using node's "assert" library.

What change is being introduced by this PR?

Replacing all possible "expect" calls from jest with the correspondent ones from "assert", so the changes in the next PR are smaller.

How will this be tested?

Tests are passing in the same way.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1227117) 80.00% compared to head (f47a64a) 80.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files          20       20           
  Lines        1270     1270           
  Branches      191      191           
=======================================
  Hits         1016     1016           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

__tests__/__main__/time-math.js Outdated Show resolved Hide resolved
__tests__/__main__/time-math.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Outdated Show resolved Hide resolved
__tests__/__main__/validate-json.js Show resolved Hide resolved
@tupaschoal tupaschoal merged commit a0653a5 into thamara:main Jan 28, 2024
9 checks passed
@araujoarthur0 araujoarthur0 deleted the switch-to-assert branch January 29, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants