Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1027: Avoid update-changelog to generate an extra line when there are no changes #1029

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

araujoarthur0
Copy link
Collaborator

Related issue

Closes #1027

Context / Background

update-changelog.py was adding an extra empty line to the section below every time the bot was called while there were no changes in the current release.

<!--- Begin changes - Do not remove -->

<!--- End changes - Do not remove -->

For example: 322a4d3

This extra line gets a linter complaint every time and then causes problems for the next PR.

This is not a common problem because we don't often have no changes, though.
Just now we got the first change.

What change is being introduced by this PR?

  • Updating the actions we use to the latest to avoid some warnings.
  • No longer adding an extra line in the script when there's no change.

How will this be tested?

Ran it locally against an empty changelog.md and against a filled changelog.md.

@araujoarthur0 araujoarthur0 requested a review from thamara November 1, 2023 01:16
@araujoarthur0 araujoarthur0 force-pushed the changelog-updater-lint branch from 694ec05 to 8149940 Compare November 1, 2023 01:20
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1029 (8149940) into main (ae757ab) will decrease coverage by 0.10%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
- Coverage   75.11%   75.02%   -0.10%     
==========================================
  Files          26       26              
  Lines        2202     2202              
  Branches      346      346              
==========================================
- Hits         1654     1652       -2     
- Misses        548      550       +2     

see 1 file with indirect coverage changes

@tupaschoal tupaschoal merged commit 542a243 into thamara:main Nov 1, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog updater bot is adding extra lines that the linter is against
2 participants