Checking lint in PR CI checks #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase as soon as #1019 is merged in, that should fix the checks. |
|
@BamButz now it should be ok |
|
Changelog Bot does not comply with your linting rules: see commit 322a4d3 |
|
Yes :( saw that earlier today #1027 |
|
Think that might be a blocker otherwise every PR will restart the issue. |
|
Can you try now again to rebase? It might have been a problem only when the file had no changes for a release - it is no longer empty. |
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 75.11% 75.11%
=======================================
Files 26 26
Lines 2202 2202
Branches 346 346
=======================================
Hits 1654 1654
Misses 548 548 |
|
\changelog-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #987
Context / Background
As described in the issue, I added linting to the CI checks to avoid introduction of linting faults.
What change is being introduced by this PR?
Checks workflow now checks for linting issues.
PR #1019 should be merged first to fix some lint errors.