-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling more formats to input hours and minutes in preferences #1020
Open
TaranDev
wants to merge
11
commits into
thamara:main
Choose a base branch
from
TaranDev:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
810675a
Changed pattern regex for time inputs in preferences.html to consider…
TaranDev 6c10744
Added checks to match input format and convert it to the internal for…
TaranDev ca90d9c
Fixed decimal point format conversion
TaranDev b86e223
Cleaned up code
TaranDev 4a7d965
Merge branch 'thamara:main' into main
TaranDev dfa941a
Update package-lock.json
TaranDev 396fa05
Update package-lock.json
TaranDev 6c15876
Update package-lock.json
TaranDev df90d57
Made hours per day and break time interval reflect converted time for…
TaranDev 2b529d6
Update changelog.md
TaranDev 3c0ed37
refactored preferences time input code
TaranDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, consider if it's possible to implement extra tests for this behavior to ensure it's always working. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When one inputs something wrong, the html message asks to follow the requested format, but that is not explicit.
Is there a way to customize that html message?