Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an animation to the workday waiver holidays table when switching contents #1015

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

araujoarthur0
Copy link
Collaborator

Related issue

Closes #1009

Before:
holidays

After:
holidays2

Also limited the min width of the date column so it stops breaking when the holiday names are too big.

@araujoarthur0
Copy link
Collaborator Author

The gifs are awfully slow, but currently there's a split second in which the table is empty and the window just pops up and down.
Now it waits in time to paint the new table.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tupaschoal
Copy link
Collaborator

Seems like the tests covering clearing the table need a look @araujoarthur0

@tupaschoal
Copy link
Collaborator

@araujoarthur0 the tests are failing cause the rows are not immediately removed because of the fadeout, need to wait for the fadeout to happen or disable them before running the tests.

@araujoarthur0
Copy link
Collaborator Author

Seems the tests are failing on main as well

@araujoarthur0
Copy link
Collaborator Author

Turns out it was also failing for me in main because of a saved preference from another test. Restoring the default preferences at the beginning of the test fixed the second issue. Now back to the animation issue.

@araujoarthur0
Copy link
Collaborator Author

The removal wasn't working because $(this) does not work in a lambda like I did.
Fixing it returns the animation problems, so I'll rethink my approach.

@araujoarthur0
Copy link
Collaborator Author

Fixed the implementation by using a temporary table in which the html operations happen in the background, and finish by switching the two tables.

Also fixed it that choosing '--' as a country was not clearing the table, and updating the year was not updating the table holidays.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1015 (e9b6178) into main (802d991) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
+ Coverage   73.17%   73.25%   +0.07%     
==========================================
  Files          26       26              
  Lines        2188     2202      +14     
  Branches      345      346       +1     
==========================================
+ Hits         1601     1613      +12     
- Misses        587      589       +2     
Files Coverage Δ
src/workday-waiver.js 77.41% <77.27%> (+0.43%) ⬆️

@araujoarthur0 araujoarthur0 merged commit ae757ab into thamara:main Oct 31, 2023
8 checks passed
@araujoarthur0 araujoarthur0 deleted the workday-animations branch October 31, 2023 21:22
@araujoarthur0
Copy link
Collaborator Author

\changelog-update
Message: Enhancement [#1009]: Adding an animation to the workday waiver holidays table when the contents switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an animation when switching states in holidays table in workday waiver page
2 participants