-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an animation to the workday waiver holidays table when switching contents #1015
Conversation
The gifs are awfully slow, but currently there's a split second in which the table is empty and the window just pops up and down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Seems like the tests covering clearing the table need a look @araujoarthur0 |
@araujoarthur0 the tests are failing cause the rows are not immediately removed because of the fadeout, need to wait for the fadeout to happen or disable them before running the tests. |
Seems the tests are failing on main as well |
Turns out it was also failing for me in main because of a saved preference from another test. Restoring the default preferences at the beginning of the test fixed the second issue. Now back to the animation issue. |
The removal wasn't working because $(this) does not work in a lambda like I did. |
61754a1
to
e9b6178
Compare
Fixed the implementation by using a temporary table in which the html operations happen in the background, and finish by switching the two tables. Also fixed it that choosing '--' as a country was not clearing the table, and updating the year was not updating the table holidays. |
Codecov Report
@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 73.17% 73.25% +0.07%
==========================================
Files 26 26
Lines 2188 2202 +14
Branches 345 346 +1
==========================================
+ Hits 1601 1613 +12
- Misses 587 589 +2
|
\changelog-update |
Related issue
Closes #1009
Before:
After:
Also limited the min width of the date column so it stops breaking when the holiday names are too big.