Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize hours per day #1077

Open
yarinl3 opened this issue Sep 18, 2024 · 6 comments · May be fixed by #1091
Open

Customize hours per day #1077

yarinl3 opened this issue Sep 18, 2024 · 6 comments · May be fixed by #1091
Labels
enhancement New feature or request

Comments

@yarinl3
Copy link

yarinl3 commented Sep 18, 2024

Describe the current limitation
In the current state you can choose days in the preferences and choose hours per day (for all days).

Describe the proposed feature or enhancement
Add option to choose hours per day for every day.
For example for days: Sun, Tue, Thu set hours-per-day to 10:15 and for Mon, Wed set hours-per-day to 11:45.

@yarinl3 yarinl3 added the enhancement New feature or request label Sep 18, 2024
@mayakost
Copy link

mayakost commented Nov 7, 2024

Has anyone taken this? If not, I'll take it. It's my first open source and I'd like to contribute.

@thamara
Copy link
Owner

thamara commented Nov 8, 2024

Hi @mayakost , I believe this is nor assigned to anyone, and I would be happy to assign it to you. But can you please provide a draft (can be a simple drawing or description) on how you propose this setting to be included?

@Rameen260
Copy link

Rameen260 commented Nov 24, 2024

image

Hi I was wondering if I could take this on as my first open source contribution. As for how I was thinking about implementing this, I had 2 different ideas in mind.
First Idea: Have another on/off option above the "HOURS PER DAY' selection that is called "SAME HOURS ALL ALL DAYS", or something like that. It will ON by default, however, if the user decides to turn it OFF they will be presented with the working days they have selected and then the user will be able to select their hours for each day.

Second Idea(simpler): Instead of having just one "HOURS PER DAY" selection, the user will be presented with the working days they have already selected, allowing them to select their hours for each day.

As for the logic after implementing it visually, I will have to look deeper into the code, any guidance would be appreciated.

@tupaschoal
Copy link
Collaborator

Thanks for your interest @Rameen260 . Before you start, let us ask @mayakost whether they are working on it

@mayakost
Copy link

mayakost commented Nov 27, 2024 via email

@Rameen260
Copy link

Hey @mayakost, I have an idea in mind, is it fine if I take the issue up on my own? This is also my first open-source contribution.

@Rameen260 Rameen260 linked a pull request Dec 10, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants