[TH2-4953] - th2 transport protocol #7
Conversation
core/src/main/kotlin/com/exactpro/th2/read/db/bootstrap/Main.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/exactpro/th2/read/db/bootstrap/Main.kt
Outdated
Show resolved
Hide resolved
| val publication: PublicationConfiguration = PublicationConfiguration() | ||
| val publication: PublicationConfiguration = PublicationConfiguration(), | ||
| val useTransport: Boolean = false, | ||
| val sessionGroup: String |
There was a problem hiding this comment.
I don't think that the single session group should be used for the whole read-db. If we want to add we need to add the ability to set the group per data source.
Otherwise, it doesn't really make sense (at least for me).
@Nikita-Smirnov-Exactpro what do you think about the current implementation and my opinion?
| private fun TableRow.toTransportMessage(dataSourceId: DataSourceId): RawMessage.Builder { | ||
| val builder = RawMessage.builder() | ||
| .setBody(Unpooled.wrappedBuffer(toCsvBody())) | ||
| .setId(MessageId(dataSourceId.id, Direction.INCOMING, 0, Instant.EPOCH)) |
There was a problem hiding this comment.
I think we should use idBuilder here (because we cannot set sequence and timestamp here)
| } | ||
| } | ||
|
|
||
| private data class SessionKey<DIRECTION>(val alias: String, val direction: DIRECTION) |
There was a problem hiding this comment.
I we use groups here the group must be used for the session key instead of the alias
version update README.md update
|
Looks okay to me. |
| sequences.compute(key) { _, prev -> | ||
| if (prev == null) { | ||
| Instant.now().run { epochSecond * nanosInSecond + nano } | ||
| } else { | ||
| prev + 1 | ||
| } |
There was a problem hiding this comment.
This can be moved to the parent class
|
@lumber1000 Are you okay to merge the changes? |
dev release workflow added
core/build.gradle
Outdated
| @@ -12,7 +14,7 @@ ext { | |||
| coroutines_version = '1.6.4' | |||
There was a problem hiding this comment.
I think we need to update the coroutines version because we have updated the kotlin version
version update dev release workflow added
| - versions | ||
| uses: th2-net/.github/.github/workflows/compaund-python-grpc-pypi-publication.yml@main | ||
| with: | ||
| custom-version: ${{ needs.versions.outputs.version }}-dev |
There was a problem hiding this comment.
Please, use .rc1 suffix instead of -dev
| uses: th2-net/.github/.github/workflows/compaund-java-docker-push.yml@main | ||
| with: | ||
| docker-username: ${{ github.actor }} | ||
| version: ${{ needs.versions.outputs.version }}-dev |
There was a problem hiding this comment.
From which project this version is taken? By default th2-net/.github/.github/workflows/compound-prebuild-java-workflow.yml@main takes the version from the root project. But this is not what we won't. The version should be taken from app project. You need to specify the project path to get the right version
build.gradle
Outdated
| id "org.owasp.dependencycheck" version "8.1.2" | ||
| id "io.github.gradle-nexus.publish-plugin" version "1.3.0" | ||
| id 'org.jetbrains.kotlin.jvm' version '1.8.22' apply false | ||
| id "org.owasp.dependencycheck" version "8.3.1" |
There was a problem hiding this comment.
Please, add plugins for licenses and git properties
grpc/build.gradle
Outdated
There was a problem hiding this comment.
Please, take a look at other grpc repos (check1 for example - the latest dev tag) and correct the sourceSets block
.github/workflows/dev-release-java-publish-sonatype-and-docker.yml
Outdated
Show resolved
Hide resolved
| @@ -31,4 +37,21 @@ dependencyCheck { | |||
|
|
|||
| dependencyLocking { | |||
| lockAllConfigurations() | |||
| } | |||
|
|
|||
| licenseReport { | |||
There was a problem hiding this comment.
Does this plugin work for subproject when you apply it to the root project? Could you please check that?
No description provided.