Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS-1928] Support keepOpen option for searchMessageGroups gRPC r… #86

Draft
wants to merge 8 commits into
base: dev-version-2
Choose a base branch
from

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

…equest

Copy link

github-actions bot commented Oct 4, 2024

Test Results

7 tests  ±0   7 ✅ ±0   0s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 61b35e0. ± Comparison against base commit d4c6690.

♻️ This comment has been updated with latest results.

grpc/README.md Show resolved Hide resolved
utils/README.md Show resolved Hide resolved
@Nikita-Smirnov-Exactpro
Copy link
Member Author

@isengrims : Current version has the problem internal task isn't canceled when deadline exceeded or message with timestamp more than request end time got from cradle

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the title [TH2-1928] Support keepOpen option for searchMessageGroups gRPC r… [TS-1928] Support keepOpen option for searchMessageGroups gRPC r… Oct 29, 2024
@@ -140,6 +140,7 @@ class SearchMessagesHandler(
val allLoaded = hashSetOf<Stream>()
do {
val continuePulling = pullUpdates(request, order, sink, allLoaded)
Thread.sleep(configuration.keepOpenPullingTimeoutMs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: please check if we should keep pulling before calling sleep method. As an alternative, I think you can call sleep method before calling pullUpdates. I think it would make sense to wait a bit before first pull attempt as well


assertInstanceOf<CancelableResponseHandler>(capturedRequestContext)

Thread.sleep(200)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: you could use awaitility library instead of sleep call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants