Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[th2-5232] Updated dependencies #85

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[th2-5232] Updated dependencies #85

merged 2 commits into from
Aug 20, 2024

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro commented Aug 20, 2024 •
edited
Loading

This Pull request included:

  • Dependencies update
  • Migration from io.github.microutils:kotlin-logging to io.github.oshai:kotlin-logging
  • CVE-2019-3826 suppression

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Test Results

7 tests  ±0   7 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 8eec6ce. ± Comparison against base commit 6517607.

♻️ This comment has been updated with latest results.

OptimumCode
OptimumCode approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, correct the PR name. You didn't just update the cradle API. You also updated other libraries and made some code changes

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit 4e41664 into dev-version-2 Aug 20, 2024
13 checks passed
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the title [th2-5232] Updated cradle api: 5.4.2-dev [th2-5232] Updated dependencies Aug 20, 2024
@Nikita-Smirnov-Exactpro
Copy link
Member Author

Please, correct the PR name. You didn't just update the cradle API. You also updated other libraries and made some code changes

Topic was changed, details were added to description

@OptimumCode
Copy link
Member

Topic was changed, details were added to description

Yes, but you did it before the merge and now the commit in the main branch has the old name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OptimumCode OptimumCode OptimumCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nikita-Smirnov-Exactpro @OptimumCode