-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to th2 gradle plugin 0.0.6
#82
Migrate to th2 gradle plugin 0.0.6
#82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I honestly don't understand the reason why you decided to do everything at once. Update dependencies, migrate to th2 gradle plugin, move LDP project from root to app folder, migrate from groovy to kts, migrate from buildSrc to using subprojects configuration in root build.gradle... As a result of this decision, there are 206 updated files and absolutely new build files in each project. How is anybody supposed to track those changes? What was updated and what was left as is? I believe the changes like this should be done in several steps (ideally each one - or closely related changes - in separate PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: I don't see a CI build for the latest commit.
There is an error message for workflow run - The workflow is not valid. .github/workflows/dev-build.yml (Line: 62, Col: 20): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.NVD_APIKEY
Thank you, I have corrected workflows |
No description provided.