Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to th2 gradle plugin 0.0.6 #82

Merged
merged 15 commits into from
May 15, 2024

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 13, 2024

Test Results

7 tests  +7   7 ✅ +7   0s ⏱️ ±0s
1 suites +1   0 💤 ±0 
1 files   +1   0 ❌ ±0 

Results for commit 5b8110e. ± Comparison against base commit 97340f5.

♻️ This comment has been updated with latest results.

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro marked this pull request as ready for review May 14, 2024 11:43
Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I honestly don't understand the reason why you decided to do everything at once. Update dependencies, migrate to th2 gradle plugin, move LDP project from root to app folder, migrate from groovy to kts, migrate from buildSrc to using subprojects configuration in root build.gradle... As a result of this decision, there are 206 updated files and absolutely new build files in each project. How is anybody supposed to track those changes? What was updated and what was left as is? I believe the changes like this should be done in several steps (ideally each one - or closely related changes - in separate PR).

.github/workflows/build.yml Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
app/build.gradle.kts Outdated Show resolved Hide resolved
grpc/setup.py Outdated Show resolved Hide resolved
app/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: I don't see a CI build for the latest commit.
There is an error message for workflow run - The workflow is not valid. .github/workflows/dev-build.yml (Line: 62, Col: 20): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.NVD_APIKEY

gradle/libs.versions.toml Outdated Show resolved Hide resolved
OptimumCode
OptimumCode previously approved these changes May 15, 2024
app/build.gradle.kts Outdated Show resolved Hide resolved
@OptimumCode OptimumCode dismissed their stale review May 15, 2024 08:44

This must be solved first: #82 (review)

@Nikita-Smirnov-Exactpro
Copy link
Member Author

issue: I don't see a CI build for the latest commit. There is an error message for workflow run - The workflow is not valid. .github/workflows/dev-build.yml (Line: 62, Col: 20): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.NVD_APIKEY

Thank you, I have corrected workflows

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit f770898 into dev-version-2 May 15, 2024
13 checks passed
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro deleted the migrate-to-th2-gradle-plugin branch May 15, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants