[TH2-5226] infra-operator periodically deletes redundant resources from RabbitMQ instead of remove on start #119
Conversation
Nikita-Smirnov-Exactpro
changed the title
Nikita-Smirnov-Exactpro
changed the title
src/main/java/com/exactpro/th2/infraoperator/spec/strategy/linkresolver/mq/RabbitMQContext.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exactpro/th2/infraoperator/spec/strategy/linkresolver/mq/RabbitMQContext.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/infraoperator/spec/strategy/redeploy/tasks/RabbitMQGcTask.kt
Outdated
Show resolved
Hide resolved
* Updated GitHub workflow
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
src/main/java/com/exactpro/th2/infraoperator/Th2CrdController.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/infraoperator/configuration/fields/RabbitMQManagementConfig.kt
Outdated
Show resolved
Hide resolved
|
|
||
| K_LOGGER.debug { "Actual set in RabbitMQ, queues: $queues, exchanges: $exchanges" } | ||
|
|
||
| if (isHolderEmpty() || namespaces.isEmpty()) { |
There was a problem hiding this comment.
note: The namespace check can be moved closer to the start of the method (right after you collect the namespaces)
There was a problem hiding this comment.
We couldn't do that because code above gets th2 queues and exchanges from RabbitMQ, they are rubbish in namespace case
There was a problem hiding this comment.
Got it, thank you for explaining this. In my opinion, it would be clearer if we split this function into two - the one that collects the information about queues and exchanges and another one that filters the live queue and exchanges from the collected data. This is just a suggestion - you are free to ignore it
src/main/kotlin/com/exactpro/th2/infraoperator/util/RabbitMQUtils.kt
Outdated
Show resolved
Hide resolved
…ils.kt Co-authored-by: Oleg Smirnov <[email protected]>
|
State from this PR migrated to #123 |
No description provided.